-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid usage by waiting on CommandBuffer fence before resetting CommandBuffer #1795
Fix invalid usage by waiting on CommandBuffer fence before resetting CommandBuffer #1795
Conversation
CI gfxreconstruct build queued with queue ID 274089. |
CI gfxreconstruct build queued with queue ID 274095. |
CI gfxreconstruct build # 4983 running. |
CI gfxreconstruct build # 4983 passed. |
CI gfxreconstruct build queued with queue ID 275201. |
CI gfxreconstruct build # 5013 running. |
CI gfxreconstruct build # 5013 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments. I haven't spent any time in this part of the code so I'm coming up to speed myself.
I don't understand this (why does it only apply to the first swapchain image?): https://github.com/LunarG/gfxreconstruct/blob/dev/framework/decode/vulkan_virtual_swapchain.cpp#L776-L783
And this also looks a little fishy (why is it using present_info->waitSemaphoreCount
?)
https://github.com/LunarG/gfxreconstruct/blob/dev/framework/decode/vulkan_virtual_swapchain.cpp#L880-L884
* Add fences to per-image copy resource * Save device in swapchain state * Give fence to QueueSubmit to signal * Wait on fence before resetting commandbuffer
18291b5
to
dcd6a4d
Compare
CI gfxreconstruct build queued with queue ID 284779. |
CI gfxreconstruct build # 5151 running. |
CI gfxreconstruct build # 5151 passed. |
CI gfxreconstruct build queued with queue ID 284802. |
CI gfxreconstruct build # 5152 running. |
CI gfxreconstruct build queued with queue ID 284819. |
CI gfxreconstruct build queued with queue ID 284834. |
CI gfxreconstruct build queued with queue ID 284835. |
CI gfxreconstruct build queued with queue ID 284850. |
CI gfxreconstruct build # 5156 running. |
CI gfxreconstruct build # 5156 passed. |
See also KhronosGroup/Vulkan-ValidationLayers#8655